Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update SETUP.md to include part about format on save #1306

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

AliceR
Copy link
Member

@AliceR AliceR commented Dec 9, 2024

Related Ticket: #1263

Description of Changes

Developers should configure their IDEs or text editors to automatically format code on save.
This ensures code is consistently styled as per project standards before it even reaches version control.

This adds documentation in SETUP.md on how to configure format-on-save for VS Code.

Validation / Testing

Follow the steps described in the SETUP.md. Confirm that everything formats as expected.

@AliceR AliceR requested a review from hanbyul-here December 9, 2024 08:37
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit fc0375e
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67643b1af4591f0008af4c8b
😎 Deploy Preview https://deploy-preview-1306--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AliceR AliceR changed the title Update SETUP.md to include part about format on save [Chore] Update SETUP.md to include part about format on save Dec 9, 2024
@AliceR AliceR changed the title [Chore] Update SETUP.md to include part about format on save chore: Update SETUP.md to include part about format on save Dec 9, 2024
Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the setup docs, @AliceR

@AliceR AliceR added the documentation Improvements or additions to documentation label Dec 11, 2024
@hanbyul-here hanbyul-here requested a review from vgeorge December 16, 2024 15:24
Ensure ESLint is set as the default formatter:
```json
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
```
Copy link
Collaborator

@sandrahoang686 sandrahoang686 Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able to sortof follow.. following step 2, couldn't figure out where to add snippet so just opened command palette with cmd+shift+p and found Open User Settings (json) and then added snippet.

Also must be a small typo but i dont think json is meant to be after the "```"

Comment on lines 82 to 85
Ensure ESLint is set as the default formatter:
```json
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
```
Copy link
Member Author

@AliceR AliceR Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ensure ESLint is set as the default formatter:
```json
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
```
Set ESLint as the default formatter:
**Using Settings UI**: Open the Command Palette (Cmd+Shift+P or Ctrl+Shift+P), select Preferences: Open Settings (UI), search "default formatter," and select ESLint.
**Using JSON**: Open Preferences: Open User Settings (JSON) and add:
` "editor.defaultFormatter": "dbaeumer.vscode-eslint"`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandrahoang686 ! Do you think adding more detailed instructions would help? I did not want to go too much into vs code specifics, as people may be using different editors. Maybe with the updated note below, we don't need to change anything here at all? Let me know what you think!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think that helps! thanks for working on this & updating 🙇🏼‍♀️

docs/development/SETUP.md Outdated Show resolved Hide resolved
@AliceR AliceR merged commit 241c32f into main Dec 19, 2024
9 of 10 checks passed
@AliceR AliceR deleted the chore-setup-md branch December 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants